Skip to content

gui: show wallet name in progress messages#939

Open
ShauryaaSharma wants to merge 1 commit into
bitcoin-core:masterfrom
ShauryaaSharma:wallet-name-in-progress-messages
Open

gui: show wallet name in progress messages#939
ShauryaaSharma wants to merge 1 commit into
bitcoin-core:masterfrom
ShauryaaSharma:wallet-name-in-progress-messages

Conversation

@ShauryaaSharma

@ShauryaaSharma ShauryaaSharma commented Jun 15, 2026

Copy link
Copy Markdown

What

Include the wallet display name in the initMessage calls made during
wallet loading so the splash screen clearly identifies which wallet is
being processed:

  • LoadWalletInternal: "Loading wallet…" → "[wallet_name] Loading wallet…"
  • CreateWallet: "Creating wallet…" → "[wallet_name] Creating wallet…"
  • CWallet::AttachChain: "Rescanning…" → "[wallet_name] Rescanning…" (primary fix)

For unnamed (default) wallets, DisplayName() already returns the
translated "default wallet" string, handling that case correctly.

A comment is added to LoadWalletsActivity::load() explaining why no
specific wallet name is shown there — it loads multiple wallets
simultaneously from the node's wallet list.

Why

When a wallet that has not been synchronized recently is opened — either
via settings.json at startup or via File > Open Wallet — the splash
screen shows a bare "Rescanning…" with no indication of which wallet
is being scanned. Users with multiple wallets have no way to know which
one is being processed without checking the debug log.

The ShowProgress calls inside ScanForWalletTransactions already use
"[wallet_name] Rescanning…" (lines 1888/1903/2008); this change makes
the preceding initMessage consistent with them.

Fixes #259

@ShauryaaSharma
gui: show wallet name in progress messages
5d2ff0e 
Include the wallet display name in initMessage calls for
"Loading wallet...", "Creating wallet...", and "Rescanning..."
so the splash screen clearly identifies which wallet is being
processed at startup.

For unnamed (default) wallets, DisplayName() returns the
translated "default wallet" string.

Add a comment to LoadWalletsActivity::load() noting that
no wallet name is shown there because multiple wallets
may be loading simultaneously.

Fixes bitcoin-core#259
@DrahtBot

DrahtBot commented Jun 15, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Reviews

See the guideline for information on the review process.
A summary of reviews will appear here.

Conflicts

Reviewers, this pull request conflicts with the following ones:

If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

@ShauryaaSharma ShauryaaSharma mentioned this pull request Jun 15, 2026
Open
@DrahtBot DrahtBot mentioned this pull request Jun 18, 2026
Draft
@DrahtBot DrahtBot mentioned this pull request Jun 25, 2026
Draft
@ShauryaaSharma

ShauryaaSharma commented Jun 28, 2026

Copy link
Copy Markdown
Author

Hi @hebasto @fanquake , gentle ping on this one!

Small UX consistency fix, no logic changes, only initMessage call-site text updates across two files.

Problem: when a wallet that hasn't synced recently is opened (via settings.json at startup or File > Open Wallet), the splash screen shows a bare "Rescanning…" with no indication of which wallet is being scanned. Users with multiple wallets have to check the debug log to find out.

Fix: include DisplayName() in three initMessage calls:

  • LoadWalletInternal: "Loading wallet…" → "[wallet_name] Loading wallet…"
  • CreateWallet: "Creating wallet…" → "[wallet_name] Creating wallet…"
  • CWallet::AttachChain: "Rescanning…" → "[wallet_name] Rescanning…" ← primary fix

DisplayName() already returns the translated "default wallet" string for unnamed wallets, so that case is handled correctly without extra logic.

Consistency note: ShowProgress calls inside ScanForWalletTransactions (lines 1888/1903/2008) already use "[wallet_name] Rescanning…" , this change makes the preceding initMessage consistent with them.

Re conflicts with #30343 and #25722: both are drafts and neither has been merged. Happy to rebase once either lands if that helps move things forward.

Fixes #259.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

When opening or autoloading wallets there should be clear messages about rescanning in progress and wallets' names.

2 participants

@ShauryaaSharma @DrahtBot